feat: Unit tests for dbt models #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saraburns1
force-pushed
the
saraburns1_dbt_unittests
branch
3 times, most recently
from
3bcccf9
to
fcc4d60
Compare
saraburns1
force-pushed
the
saraburns1_dbt_unittests
branch
from
7a1718c
to
ab617c5
Compare
saraburns1
commented
Aug 2, 2024
| @@ -3,6 +3,6 @@ | |||
| -- or is followed by '/answer' or '/hint' | |||
| {% macro get_problem_id(object_id) %} | |||
| regexpExtract( | |||
| object_id, 'xblock/([\w\d-\+:@]*@problem\+block@[\w\d][^_]*)(_\d_\d)?', 1 | |||
| object_id, 'xblock/([\w\d-\+:@]*@problem\+block@[\w\d][^_\/]*)(_\d_\d)?', 1 | |||
There was a problem hiding this comment.
This regexp was not removing '/answer' from the end of the string which caused data to be excluded in subsequent queries
saraburns1
force-pushed
the
saraburns1_dbt_unittests
branch
2 times, most recently
from
5fcb938
to
decb470
Compare
saraburns1
commented
Aug 5, 2024
| rows: | | ||
| select * from section_video_engagement_expected | ||
|
|
||
| # - name: test_subsection_video_engagement |
There was a problem hiding this comment.
these are having an issue I can't figure out right now but I wanted to get the rest of this code up for review
Ian2012
reviewed
Aug 5, 2024
Ian2012
reviewed
Aug 5, 2024
Ian2012
reviewed
Aug 5, 2024
Ian2012
reviewed
Aug 5, 2024
Ian2012
reviewed
Aug 5, 2024
Ian2012
reviewed
Aug 5, 2024
saraburns1
force-pushed
the
saraburns1_dbt_unittests
branch
from
244d249
to
f063d40
Compare
bmtcril
approved these changes
Aug 7, 2024
This was referenced Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit tests for all models using a known good data set
Closes #102
notes: