Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add pypi-publish workflow #19

Merged
merged 2 commits into from
May 18, 2023
Merged

build: add pypi-publish workflow #19

merged 2 commits into from
May 18, 2023

Conversation

UsamaSadiq
Copy link
Member

Description

  • Added pypi-publish.yml workflow to publish the package on PyPI.
  • Tested the change on test-PyPI by publishing and downloading build.

@UsamaSadiq UsamaSadiq mentioned this pull request May 17, 2023
Closed
kdmccormick
kdmccormick approved these changes May 17, 2023
View reviewed changes
Copy link
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one comment.

setup.py Outdated Show resolved Hide resolved
@UsamaSadiq UsamaSadiq merged commit fa8607d into master May 18, 2023
@kdmccormick kdmccormick deleted the usamasadiq/add-pypi-publish-workflow branch May 18, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdmccormick kdmccormick kdmccormick approved these changes

@awais786 awais786 awais786 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@UsamaSadiq @awais786 @kdmccormick