Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add mismatch check to lockfile workflow #89

Merged

Conversation

Syed-Ali-Abbas-Zaidi
Copy link
Contributor

@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi commented Aug 7, 2023

Ticket

Prototype a way to review NPM lockfiles in PRs.

Description

This PR adds the workflow to detect mismatches between package.json and package-lock.json.

@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi marked this pull request as draft August 7, 2023 09:59
@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi self-assigned this Aug 7, 2023
@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi marked this pull request as ready for review August 24, 2023 08:21
Copy link

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arbrandes arbrandes merged commit aa20ddc into openedx:master Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants