This repository has been archived by the owner on May 1, 2024. It is now read-only.
feat: deprecate learner view code #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alangsto
force-pushed
the
alangsto/remove_learner_view
branch
8 times, most recently
from
c051f29
to
d30e8ff
Compare
Codecov Report
@@ Coverage Diff @@
## master #571 +/- ##
==========================================
+ Coverage 97.48% 97.52% +0.03%
==========================================
Files 63 54 -9
Lines 3944 3026 -918
Branches 554 412 -142
==========================================
- Hits 3845 2951 -894
+ Misses 68 63 -5
+ Partials 31 12 -19
Continue to review full report at Codecov.
|
alangsto
force-pushed
the
alangsto/remove_learner_view
branch
8 times, most recently
from
f5b8ed6
to
19990cb
Compare
ashultz0
reviewed
Jul 27, 2022
| @@ -1,28 +1,6 @@ | |||
| from django.apps import AppConfig | |||
| from django.conf import settings | |||
| from elasticsearch_dsl import connections | |||
There was a problem hiding this comment.
can we strip elasticsearch support out of requirements?
There was a problem hiding this comment.
Just ripped it out!
ashultz0
reviewed
Jul 27, 2022
| @@ -134,24 +95,6 @@ def status_code(self): | |||
| return status.HTTP_400_BAD_REQUEST | |||
|
|
|||
|
|
|||
| class ParameterValueErrorMiddleware(BaseProcessErrorMiddleware): | |||
There was a problem hiding this comment.
I like how you've found and smashed these associated classes
ashultz0
reviewed
Jul 27, 2022
| 'number_of_replicas': 0 | ||
| } | ||
| ELASTICSEARCH_INDEX_SETTINGS = environ.get('ELASTICSEARCH_INDEX_SETTINGS', DEFAULT_ELASTICSEARCH_INDEX_SETTINGS) | ||
| ########## END ELASTICSEARCH CONFIGURATION |
|
I'm pretty heartened that you were able to get rid of the elasticsearch stuff even without removing module engagement |
alangsto
force-pushed
the
alangsto/remove_learner_view
branch
2 times, most recently
from
ad65019
to
a27eb62
Compare
alangsto
force-pushed
the
alangsto/remove_learner_view
branch
from
a27eb62
to
6899a05
Compare
ashultz0
approved these changes
Jul 27, 2022
This was referenced Dec 18, 2022
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all code related to learner specific data. This includes