Remove bok-choy usage #4093
Remove bok-choy usage #4093
Conversation
salman2013
force-pushed
the
salman/remove-bok-choy
branch
from
da6fc8c
to
cd4d881
Compare
There was a problem hiding this comment.
Looks like you got it working by moving this whole file over, do we need the whole file or are you planning on removing everything that you don't need now that you've got the tests passing?
There was a problem hiding this comment.
@feanil Yes i have looked into few methods which are not required so i am going to remove them in the coming commits, The purpose of tagging was a preliminary review if this strategy looks fine? I have tried so many things with the selenium browser but the test was not passing due to some webdriver conflicts.
There was a problem hiding this comment.
yea, I think you're going in the right direction, let me know when this is ready for another round of review. Hopefully we can drop most of the copied file but I'm okay with leaving it in if necessary.
There was a problem hiding this comment.
@feanil It's ready for another round, i removed a few of the methods but some need to be there.
|
@salman2013 there are some conflicts on this branch, can you rebase and resolve them. I think after that, this is good to merge. |
|
@feanil I have already resolved the conflicts and it seems its good to merge. |
|
It still looks like it can't be merged to me: |
salman2013
force-pushed
the
salman/remove-bok-choy
branch
from
eb96709
to
a2cb91f
Compare
|
@feanil could you please look at it again, thanks |
#Description
As the bok-choy has been deprecated openedx/public-engineering#13, we are removing its usage from the code in this PR.
Ticket: https://github.com/orgs/openedx/projects/55/views/1?pane=issue&itemId=49965514