This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
fix: ignore Braze frequency capping for ent emails #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
long74100
reviewed
Jan 6, 2022
| @@ -300,6 +300,11 @@ def send_message( # pylint: disable=dangerous-default-value | |||
| ): | |||
| """ | |||
| Sends the message via Braze Rest API /messages/send | |||
| The "override_frequency_capping" key in the request payload is important; | |||
| it tells Braze to ignore the global campaign message frequency cap | |||
| for the message we're sending in this method. Since this is a transactional | |||
long74100
reviewed
Jan 6, 2022
| 'recipient_subscription_state': 'all', | ||
| 'messages': { | ||
| 'email': email | ||
| } | ||
| } | ||
| if campaign_id: |
There was a problem hiding this comment.
might not matter in the context of ecommerce-worker since all messages are probably transactional, but should override_frequency_capping be passed in rather than rely on the existence of campaign_id?
There was a problem hiding this comment.
Hmm, IDK. To me, send_message() is only for transactional emails, and those should never be subject to the frequency cap. I could state the assumption clearly in the docstring, maybe?
There was a problem hiding this comment.
actually, I guess the docstring already states this pretty clearly.
long74100
approved these changes
Jan 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anyone merging to this repository is expected to release and monitor their changes; if you are not able to do this DO NOT MERGE, please coordinate with someone who can to ensure that the changes are released.
Merge checklist:
requirements/*.txtfiles)base.inif needed in productiontest.infor test requirementsmake upgrade && make requirementshave been run to regenerate requirementsPost merge:
(so basically once your build finishes, after maybe a minute you should see the new version in PyPi automatically (on refresh))
make upgradein ecommerce will look for the latest version in PyPi.ecommerceecomworkeron GoCD.released via GoCD.