-
Notifications
You must be signed in to change notification settings - Fork 422
docs: Update Docker links in Getting Started docs #1122
Conversation
Thanks for the pull request, @MimmyJau! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Hi @MimmyJau, thank you for this contribution! We'll get tests enabled for you next. |
@MimmyJau Looks like most of the tests finished successfully :) Could you please have a look at the ones that failed? Once the build is green we'll start the process of getting this PR lined up for review. |
Thanks @itsjeyd. According to the logs, seems like the error is:
Could this possibly be resolved by upgrading to It's not completely clear to me how to fix this. But if there's something I can do, happy to make the changes with some guidance. |
@MimmyJau Thanks for checking. It looks like the build on #1132 is failing, too (albeit with a different error). It might still make sense to test your theory by cherry-picking the changes from #1132 to your branch and seeing if that gets rid of the Another thing that might help would be to bring your branch up to date with If the problem persists after completing both of these steps, we can start pinging technical reviewers for help. |
Links currently redirect to: https://docs.docker.com/desktop/get-started/ Archive of Mac Install link: https://web.archive.org/web/20220328231039/https://docs.docker.com/desktop/mac/ Archive of Windows Install link: https://web.archive.org/web/20220629164719/https://docs.docker.com/desktop/windows/
55c173b
to
e350316
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@MimmyJau 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Links currently redirect to: https://docs.docker.com/desktop/get-started/ Archive of Mac Install link: https://web.archive.org/web/20220328231039/https://docs.docker.com/desktop/mac/ Archive of Windows Install link: https://web.archive.org/web/20220629164719/https://docs.docker.com/desktop/windows/ Co-authored-by: Edward Zarecor <[email protected]>
Links currently redirect to:
https://docs.docker.com/desktop/get-started/
Archive of Mac Install link:
https://web.archive.org/web/20220328231039/https://docs.docker.com/desktop/mac/
Archive of Windows Install link:
https://web.archive.org/web/20220629164719/https://docs.docker.com/desktop/windows/
I've completed each of the following or determined they are not applicable: