Draft: chore(build): replace k8s.io/utils/mount with k8s.io/mount-utils #575
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently waiting for openebs/lib-csi#21 to be merged. I'm replacing the upstream dependency with my fork, after lib-csi has been updated, I will remove that
replace
.Pull Request template
Please, go through these steps before you submit a PR.
Why is this PR required? What issue does it fix?:
On Nodes with high mount activity, older versions of k8s mount-utils (or
utils/mount
) would callConsistentRead
to workaround a kernel bug which would skip mount entries on mount activity during a read.See kubernetes/mount-utils@4ae857e
We noticed that the zfs provisioner would return an
InconsistentRead
error when the node was attaching a lot of volumes (mostly after reboots).What this PR does?:
replaces the k8s.io/utils/mount dependency with k8s.io/mount-utils
the upstream package has been renamed: https://github.com/kubernetes/utils/tree/master/mount
The new version also includes the aforementioned fix.
Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
I'm not exactly sure why
go mod tidy
deems it necessary to also bump the module version (as well as some package versions). I assume some library requires an up to date go version, which is why this module now has to require that version as well.Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>