feat(deps): Bump golang, k8s and lib-csi versions #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubham14bajpai
force-pushed
the
bump
branch
5 times, most recently
from
7757ae0 to
66d574d
Compare
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
shubham14bajpai
force-pushed
the
bump
branch
10 times, most recently
from
f71facd to
de27920
Compare
niladrih
reviewed
May 28, 2023
There was a problem hiding this comment.
Hey, thanks for this change. Might be a good idea to remove the vendor directory.
This entails few other minor changes:
- Github actions workflows exclusions
- Makefile
-mod=vendorto-mod=modoptions. Removing the module paths' 'vendor/' prefix. - makefile grep command exclusions
niladrih
reviewed
May 28, 2023
There was a problem hiding this comment.
Might be a good idea to switch out github.com/ghodss/yaml with sigs.k8s.io/[email protected]
niladrih
reviewed
May 28, 2023
There was a problem hiding this comment.
Might be a good idea to switch out github.com/ghodss/yaml with sigs.k8s.io/[email protected]
- go: 1.19.9 - k8s: v1.27.2 - klog: v2 - lib-csi: v0.7.0 Signed-off-by: shubham <[email protected]>
niladrih
approved these changes
May 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does?:
This PR updates the following components:
Does this PR require any upgrade changes?:
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>