fix(restore): adding support to restore in an encrypted pool #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #292 +/- ##
======================================
Coverage 1.08% 1.08%
======================================
Files 11 11
Lines 918 918
======================================
Hits 10 10
Misses 908 908 Continue to review full report at Codecov.
|
Encrypted pool does not allow the volume to be pre created for the restore purpose. Here changing the design to do the restore first and then create the ZFSVolume object which will bind the volume already created while doing restore. Signed-off-by: Pawan <[email protected]>
Signed-off-by: Pawan <[email protected]>
mynktl
approved these changes
Mar 1, 2021
kmova
approved these changes
Mar 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #286
Signed-off-by: Pawan [email protected]
Why is this PR required? What issue does it fix?:
Encrypted pool does not allow the volume to be pre created for the
restore purpose.
What this PR does?:
Here changing the design to do the restore first and then create the ZFSVolume object which will bind the volume already created while doing restore.
Since, the volume gets created while doing the restore, so we need to pass the volume spec and use zfs properties while firing the restore command. Earlier volume was getting created before hand with all the properties so we don't need to pass that while doing the restore.
Does this PR require any upgrade changes?:
PR handles backward compatibility.