feat(upgrade): support parallel/faster upgrades for node daemonset #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For ZFSPV, all the node daemonset pods can go into the terminating state at the same time since it does not need any minimum availability of those pods. Changing maxUnavailable to 100% so that K8s can upgrade all the daemonset pods parallelly. Signed-off-by: Pawan <[email protected]>
|
@pawanpraka1 -- has upgrade from previously installed setup to this new operator.yaml with changes tested? In the past I had seen that when upgrade options are changed, we might have to delete some objects and then patch. |
|
@kmova, I have tested the upgrade on my Rancher setup, did not face any issue. Could you elaborate more about the issue, which object we need to delete and why? |
|
usually changing the default value of upgrade type, requires removing that json object from the deployment spec and recreating. Had faced this issue when changin from rollingUpgrade to recreate. In this case as it is not changing, it should be fine. |
kmova
approved these changes
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pawan [email protected]
Why is this PR required? What issue does it fix?:
For ZFSPV, all the node daemonset pods can go into the terminating state at
the same time since it does not need any minimum availability of those pods.
What this PR does?:
Changing maxUnavailable to 100% so that K8s can upgrade all the daemonset
pods parallelly. Also added labels to all the pods.