fix(zfspv): fixing data loss in case of pod deletion

When we delete the pod, we get the unmount request for the old pod
and mount request for the new pod. When unmount is done by the driver
and system is slow in processing the umount request for the volume, the driver
assumes that unmount has done and proceeded to delete the mountpath,
as unmount has not done completely, the driver will delete the data
as part of cleaning up for the NodeUnPublish request.

The driver is using os.RemoveAll which is very risky as it will clean
child also, since the mountpoint is not supposed to have anything,
just os.Remove is sufficient and it will fail if there is anything there.

Signed-off-by: Pawan <[email protected]>

pkg/zfs/mount.go

@@ -78,9 +78,8 @@ func UmountVolume(vol *apis.ZFSVolume, targetPath string,
 		}
 	}
 
-	if err := os.RemoveAll(targetPath); err != nil {
+	if err := os.Remove(targetPath); err != nil {
 		logrus.Errorf("zfspv: failed to remove mount path Error: %v", err)
-		return err
 	}
 
 	logrus.Infof("umount done path %v", targetPath)