-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cstorBackup, delete): support for snapshot deletion #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mayank <[email protected]>
Signed-off-by: mayank <[email protected]>
Signed-off-by: mayank <[email protected]>
Signed-off-by: mayank <[email protected]>
kmova
reviewed
Apr 2, 2020
kmova
reviewed
Apr 2, 2020
vishnuitta
reviewed
Apr 2, 2020
Signed-off-by: mayank <[email protected]>
vishnuitta
reviewed
Apr 3, 2020
vishnuitta
approved these changes
Apr 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes are good.. one thing is: add more comments
Signed-off-by: mayank <[email protected]>
Signed-off-by: mayank <[email protected]>
Signed-off-by: mayank <[email protected]>
kmova
reviewed
Apr 6, 2020
kmova
approved these changes
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Velero-plugin will execute clean-up operation in following scenarios:
In case of normal backup, Plugin will send delete request to api-server once the backup for the cstor volume completes
In case of scheduled backup, Plugin will send delete request, for second-last completed backup, to api-server.
If backup, normal or scheduled, is failed then plugin will send the delete request to api-server.
In case of scheduled backup,
A) If backup is last generated one then Maya-Apiserver will delete the relevant CStorBackup, CStorCompletedBackups and CStor snapshot, so next new backup will be full backup
B) If backup is not the last one then maya-apiserver will delete the relevant CStorBackup and CStor snapshot
REST API query format:
<APISERVER_ADDR>/latest/backups/<BACKUP_NAME>?volume=<VOL_NAME>&namespace=<PVC_NAMESPACE>&schedule=<SCHEDULE_NAME>
Sample query URL:
http://10.0.0.94:5656/latest/backups/emyqevym-20200401174441?volume=pvc-165d0f86-7441-11ea-9d2c-d89c67d5e4a1&namespace=app&schedule=emyqevym
Covered test cases :
Depends on: openebs-archive/maya#1644
Fixes: openebs/openebs#2957