feat(velero): wait for plugin server to be UP before doing backup/restore #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawanpraka1
changed the title
pawanpraka1
force-pushed
the
server
branch
2 times, most recently
from
5c0a397 to
c6dc2ed
Compare
pawanpraka1
changed the title
…restore We are starting the restore operation and then starting the server. It could lead to a connection failure if server is not ready when ZFS-LocalPV starts the restore operation. Here, we are waiting for the server to be up before starting the restore operation. Also re-factored few codes. Signed-off-by: Pawan <[email protected]>
mynktl
reviewed
Sep 24, 2020
Signed-off-by: Pawan <[email protected]>
pawanpraka1
changed the title
mynktl
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pawan [email protected]
Why is this PR required? What issue does it fix?:
We are starting the restore operation and then starting the server.
It could lead to a connection failure if server is not ready when
ZFS-LocalPV starts the restore operation.
What this PR does?:
Here, we are waiting for the server to be up before starting the
restore operation. Also re factored few codes.
Checklist:
<type>(<scope>): <subject>