-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(csi, local restore): add support for local restore of cStor CSI volume #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mittachaitu <[email protected]>
Signed-off-by: mittachaitu <[email protected]>
mynktl
reviewed
Aug 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mittachaitu PR looks good. Given few comments. PTAL.
Signed-off-by: mittachaitu <[email protected]>
… volumes and add change log file Signed-off-by: mittachaitu <[email protected]>
Signed-off-by: mittachaitu <[email protected]>
mynktl
approved these changes
Aug 26, 2020
mittachaitu
pushed a commit
to mittachaitu/velero-plugin
that referenced
this pull request
Aug 27, 2020
…olume (openebs#108) Signed-off-by: mittachaitu <[email protected]>
7 tasks
mynktl
pushed a commit
that referenced
this pull request
Aug 31, 2020
…olume (#108) (#109) Signed-off-by: mittachaitu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request template
Please, go through these steps before you submit a PR. ## Remove this line
Why is this PR required? What issue does it fix?:
This PR required to support local restore of cStor CSI volume.
What this PR does?:
This PR handles the response of restore request and populate the spec required for CStor CSI volume.
Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered and commands you used for testing with logs:
Any additional information for your reviewer?:
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>