Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(csi, local restore): add support for local restore of cStor CSI volume #108

Merged
merged 5 commits into from
Aug 26, 2020

Conversation

mittachaitu
Copy link

@mittachaitu mittachaitu commented Aug 23, 2020

Pull Request template

Please, go through these steps before you submit a PR. ## Remove this line

Why is this PR required? What issue does it fix?:
This PR required to support local restore of cStor CSI volume.

What this PR does?:
This PR handles the response of restore request and populate the spec required for CStor CSI volume.

Does this PR require any upgrade changes?:
No

If the changes in this PR are manually verified, list down the scenarios covered and commands you used for testing with logs:

  • Backup the CSI volume and restored it in a different namespace.
  • Backup the Non-CSI volume and restored it in a different namespace.

Any additional information for your reviewer?:
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

Copy link
Contributor

@mynktl mynktl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mittachaitu PR looks good. Given few comments. PTAL.

pkg/cstor/cstor.go Outdated Show resolved Hide resolved
pkg/cstor/pv_operation.go Outdated Show resolved Hide resolved
@mynktl mynktl added this to the 2.1 milestone Aug 24, 2020
@mynktl mynktl added the Bug issue/pr is a bug/fix to existing feature label Aug 24, 2020
… volumes and add change log file

Signed-off-by: mittachaitu <[email protected]>
@sonasingh46 sonasingh46 requested a review from kmova August 25, 2020 06:48
@mynktl mynktl merged commit 8a4f0b1 into openebs:master Aug 26, 2020
mittachaitu pushed a commit to mittachaitu/velero-plugin that referenced this pull request Aug 27, 2020
mynktl pushed a commit that referenced this pull request Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug issue/pr is a bug/fix to existing feature
Projects
None yet
2 participants