Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact(migrate): improve logs and docs about multiple cstorvolume apis #96

Merged
merged 3 commits into from
Mar 3, 2021

Conversation

shubham14bajpai
Copy link
Contributor

@shubham14bajpai shubham14bajpai commented Mar 1, 2021

Signed-off-by: shubham [email protected]

What this PR does:
This PR adds logs and documentation about the multiple cstorvolume apis present in the cluster during migration. When the pools are migrated and volumes are still pending for migration there may be some volumes in the newer volumes in cstorvolume.cstor.openebs.io while some will still be in older api cstorvolume.openebs.io. The changes informs the user of such situations.

This PR also bumps the version matrix for 2.7.0

Ref: https://kubernetes.slack.com/archives/CUAKPFU78/p1614522935143200?thread_ts=1614470259.132700&cid=CUAKPFU78

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • PR messages has document related information
  • Labelled this PR & related issue with documentation tag
  • PR messages has breaking changes related information
  • PR messages has upgrade related information
  • Labelled this PR & related issue with requires-upgrade tag
  • Tests updated

Copy link
Member

@niladrih niladrih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested minor convenience-based changes.

cmd/migrate/executor/cstor_pool.go Outdated Show resolved Hide resolved
cmd/migrate/executor/cstor_pool.go Outdated Show resolved Hide resolved
cmd/migrate/executor/cstor_pool.go Outdated Show resolved Hide resolved
docs/migration.md Outdated Show resolved Hide resolved
docs/migration.md Outdated Show resolved Hide resolved
cmd/migrate/executor/cstor_pool.go Outdated Show resolved Hide resolved
Copy link

@mittachaitu mittachaitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are good

@prateekpandey14 prateekpandey14 merged commit bd5b0e0 into openebs-archive:master Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants