Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact(migrate): improve logs and docs about multiple cstorvolume apis #96

Merged
merged 3 commits into from
Mar 3, 2021
Merged

refact(migrate): improve logs and docs about multiple cstorvolume apis #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
73f82b4
refact(migrate): improve logs and docs about multiple cstorvolume apis
shubham14bajpai Mar 1, 2021
4e3bdf0
addressed review comments
shubham14bajpai Mar 1, 2021
5165646
added changelog for the PR
shubham14bajpai Mar 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelogs/unreleased/96-shubham14bajpai
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
refact(migrate): improve logs and docs about multiple cstorvolume apis
4 changes: 4 additions & 0 deletions cmd/migrate/executor/cstor_pool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,5 +88,9 @@ func (m *MigrateOptions) RunCStorSPCMigrate() error {
}
klog.Infof("Successfully migrated spc %s to cspc", m.spcName)

klog.Infof("Make sure to migrate the associated PVs, "+
"to list CStorVolumes for the PVs which are pending migration use `kubectl get cstorvolume.openebs.io -n %s -l openebs.io/storage-pool-claim=%s`, "+
"and to list CStorVolumes for the migrated/CSI PVs use `kubectl get cstorvolume.cstor.openebs.io -n %s`",
m.openebsNamespace, m.spcName, m.openebsNamespace)
return nil
}
1 change: 1 addition & 0 deletions docs/migration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ I0520 10:01:25.798889 1 pool.go:80] Successfully migrated spc sparse-claim

**<span style="color: red;">Note: In case the job fails for any reason please do not scale up the old CSP deployments. It can lead to data corruption.</span>**

Make sure to migrate the associated PVs, to list CStorVolumes for the PVs which are pending for migration use `kubectl get cstorvolume.openebs.io -n <openebs-namespace> -l openebs.io/storage-pool-claim=<spc-name>` and to list CStorVolumes for the migrated/CSI PVs use `kubectl get cstorvolume.cstor.openebs.io -n <openebs-namespace>`

## cStor External Provisioned volumes to cStor CSI volumes

Expand Down
1 change: 1 addition & 0 deletions pkg/version/util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ var (
"1.10.0": true, "1.11.0": true, "1.12.0": true,
"2.0.0": true, "2.1.0": true, "2.2.0": true, "2.3.0": true,
"2.4.0": true, "2.4.1": true, "2.5.0": true, "2.6.0": true,
"2.7.0": true,
}
validDesiredVersion = strings.Split(GetVersion(), "-")[0]
)
Expand Down