-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add branch preparation and release CI changes #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsharma-dc
requested review from
niladrih,
Abhinandan-Purkait and
tiagolobocastro
and removed request for
niladrih
September 27, 2024 10:23
7 tasks
Abhinandan-Purkait
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please test the flows once. You can try this on your fork.
- Merge the PR to your fork develop.
- Create a
release/X.Y
branch from your fork develop. - Wait for the Branch Prep CI, you should see 2 PRs get raised. Merge them.
- Create a tag vX.Y.Z from
release/X.Y
, all the workflows should pass and you should be able to see a new PR onrelease/X.Y
to bump the prerelease. Merge the PR.
After the above workflows, you should be able to see 2 develop charts and images, 2 prerelease. 1 actual release.
dsharma-dc
force-pushed
the
branch_prep
branch
3 times, most recently
from
October 1, 2024 11:23
2c21367
to
5685d43
Compare
dsharma-dc
force-pushed
the
branch_prep
branch
2 times, most recently
from
October 7, 2024 05:45
c404caa
to
0814c62
Compare
Signed-off-by: Diwakar Sharma <[email protected]>
dsharma-dc
force-pushed
the
branch_prep
branch
from
October 7, 2024 05:46
0814c62
to
bd0e6a3
Compare
tiagolobocastro
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed Workflow
We create the release/x.y branch on the repo from develop.
This concerned GitHub workflow kicks in.
The workflow extracts the x.y from the branch name i.e. release/x.y.
The workflow updates the chart version to x.y.0-prerelease and creates a PR against the release/x.y branch.
We are supposed to merge the PRs manually. Once the above PR is merged the PR merge workflow for the release/x.y kicks in.
This also adds the script that is capable of updating release and develop branches after tag is cut.