feat(e2e-tests): Add e2e-test for lvm-localpv driver provisioning #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
======================================
Coverage 3.87% 3.87%
======================================
Files 16 16
Lines 1290 1290
======================================
Hits 50 50
Misses 1231 1231
Partials 9 9 Continue to review full report at Codecov.
|
|
cc: @gprasath @nsathyaseelan for review |
nsathyaseelan
suggested changes
Mar 4, 2021
e2e-tests/experiments/functional/lvm-controller-high-availability/test.yml
Show resolved
Hide resolved
e2e-tests/experiments/functional/lvm-controller-high-availability/run_litmus_test.yml
Outdated
Show resolved
Hide resolved
gprasath
reviewed
Mar 8, 2021
e2e-tests/experiments/functional/lvm-controller-high-availability/README.md
Outdated
Show resolved
Hide resolved
e2e-tests/experiments/functional/lvm-controller-high-availability/README.md
Outdated
Show resolved
Hide resolved
e2e-tests/experiments/functional/lvm-controller-high-availability/README.md
Outdated
Show resolved
Hide resolved
|
|
||
| ## Exit-Criteria | ||
|
|
||
| - lvm-controller statefulset should be scaled up by one replica. |
There was a problem hiding this comment.
what will happen, if the replicas are already in HA mode
There was a problem hiding this comment.
it gets the initial replica count and increase it by one if schedule-able node is present. So if it is already in HA (say repplica:2) then it will scale it up to 3
| - lvm-controller statefulset should be scaled up by one replica. | ||
| - All the replias should be in running state. | ||
| - lvm-localpv volumes should be healthy and data after scaling up controller should not be impacted. | ||
| - This experiment makes one of the lvm-controller statefulset replica to go down, as a result active/master replica of lvm-controller prior to the experiment will be changed to some other remaining replica after the experiment completes. This happens because of the lease mechanism, which is being used to decide which replica will be serving as master. At a time only one replica will be master and other replica will follow the anti-affinity rules so that these replica pods will be present on different nodes only. |
There was a problem hiding this comment.
are we bringing down the master replica?
e2e-tests/experiments/functional/lvm-controller-high-availability/README.md
Outdated
Show resolved
Hide resolved
e2e-tests/experiments/functional/lvm-controller-high-availability/test.yml
Outdated
Show resolved
Hide resolved
e2e-tests/experiments/functional/lvm-controller-high-availability/test.yml
Outdated
Show resolved
Hide resolved
e2e-tests/experiments/functional/lvm-controller-high-availability/test.yml
Outdated
Show resolved
Hide resolved
Signed-off-by: w3aman <[email protected]>
gprasath
approved these changes
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: w3aman [email protected]