fix(localpv): ensure lvm volume creation & deletion idempotent #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawanpraka1
reviewed
Feb 1, 2021
pawanpraka1
reviewed
Feb 1, 2021
iyashu
force-pushed
the
lvmdel-idempotency
branch
2 times, most recently
from
9ad5f7e to
4b94e11
Compare
iyashu
force-pushed
the
lvmdel-idempotency
branch
from
4b94e11 to
a929ba6
Compare
iyashu
changed the title
|
@iyashu can you share you email id. I want to add signoff for this commit. |
Fixes openebs#15 Signed-off-by: Yashpal Choudhary <[email protected]>
iyashu
force-pushed
the
lvmdel-idempotency
branch
from
a929ba6 to
c44fc1e
Compare
I've added the signed off to above commit, let me know if this works now. Thanks |
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
=========================================
- Coverage 1.42% 1.41% -0.02%
=========================================
Files 11 11
Lines 702 708 +6
=========================================
Hits 10 10
- Misses 692 698 +6
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request template
Please, go through these steps before you submit a PR.
Why is this PR required? What issue does it fix?:
Fixes #15
What this PR does?:
Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>