-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(csi): handle duplicate snapshot request and support Snapshot V1beta1 APIs #70
Conversation
278d6dc
to
6083e49
Compare
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
=======================================
Coverage 53.72% 53.72%
=======================================
Files 12 12
Lines 631 631
=======================================
Hits 339 339
Misses 272 272
Partials 20 20 Continue to review full report at Codecov.
|
can you explain what is issue ("handle duplicate snapshot request for csi-snapshot") and how this PR fixes that. |
Note: Other robust solution for the the above problem is to have the getSnapshot() APIs support from istgt target to verify/get the snapshot before creating it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
@prateekpandey14 , Please resolve the conflict. |
- update the csi-snapshotter volumesnapshot and volumesnapshotcontent CRD's to v1beta1 APIs - Add openAPI validations in snapshot CRD's - add snapshot controller statefulsets container as part of v1beta1 stable APIs - Update csi snapshotter and provisioner image to required versions - Update the snapshot and snapshotclass examples with v1beta1 APIs Signed-off-by: prateekpandey14 <[email protected]>
6083e49
to
933fc31
Compare
Signed-off-by: prateekpandey14 <[email protected]>
933fc31
to
60c784c
Compare
Signed-off-by: prateekpandey14 <[email protected]>
Signed-off-by: prateekpandey14 <[email protected]>
Signed-off-by: prateekpandey14 <[email protected]>
dfa29ff
to
ebac5d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
volumesnapshotcontent CRD's to v1beta1 APIs
stable APIs
versions
CSIDriver Resource
The CSIDriver Kubernetes API object serves two purposes:
Simplify driver discovery :
If a CSI driver creates a CSIDriver object, Kubernetes users can easily discover the CSI Drivers installed on their cluster (simply by issuing kubectl get CSIDriver)
Customizing Kubernetes behavior:
Kubernetes has a default set of behaviors when dealing with CSI Drivers (for example, it calls the Attach/Detach operations by default). This object allows CSI drivers to specify how Kubernetes should interact with it.
more info https://kubernetes-csi.github.io/docs/csi-driver-object.html
Note:
Signed-off-by: prateekpandey14 [email protected]