fix(csi): handle duplicate snapshot request and support Snapshot V1beta1 APIs #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prateekpandey14
force-pushed
the
fix-snapshot
branch
from
278d6dc
to
6083e49
Compare
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
=======================================
Coverage 53.72% 53.72%
=======================================
Files 12 12
Lines 631 631
=======================================
Hits 339 339
Misses 272 272
Partials 20 20Continue to review full report at Codecov.
|
pawanpraka1
reviewed
Jan 31, 2020
|
can you explain what is issue ("handle duplicate snapshot request for csi-snapshot") and how this PR fixes that. |
Note: Other robust solution for the the above problem is to have the getSnapshot() APIs support from istgt target to verify/get the snapshot before creating it. |
|
@prateekpandey14 , Please resolve the conflict. |
- update the csi-snapshotter volumesnapshot and volumesnapshotcontent CRD's to v1beta1 APIs - Add openAPI validations in snapshot CRD's - add snapshot controller statefulsets container as part of v1beta1 stable APIs - Update csi snapshotter and provisioner image to required versions - Update the snapshot and snapshotclass examples with v1beta1 APIs Signed-off-by: prateekpandey14 <[email protected]>
prateekpandey14
force-pushed
the
fix-snapshot
branch
from
6083e49
to
933fc31
Compare
Signed-off-by: prateekpandey14 <[email protected]>
prateekpandey14
force-pushed
the
fix-snapshot
branch
from
933fc31
to
60c784c
Compare
Signed-off-by: prateekpandey14 <[email protected]>
pawanpraka1
reviewed
Feb 4, 2020
pawanpraka1
reviewed
Feb 4, 2020
pawanpraka1
reviewed
Feb 4, 2020
Signed-off-by: prateekpandey14 <[email protected]>
pawanpraka1
reviewed
Feb 4, 2020
pawanpraka1
reviewed
Feb 4, 2020
Signed-off-by: prateekpandey14 <[email protected]>
prateekpandey14
force-pushed
the
fix-snapshot
branch
from
dfa29ff
to
ebac5d6
Compare
prateekpandey14
changed the title
payes
approved these changes
Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
volumesnapshotcontent CRD's to v1beta1 APIs
stable APIs
versions
CSIDriver Resource
The CSIDriver Kubernetes API object serves two purposes:
Simplify driver discovery :
If a CSI driver creates a CSIDriver object, Kubernetes users can easily discover the CSI Drivers installed on their cluster (simply by issuing kubectl get CSIDriver)
Customizing Kubernetes behavior:
Kubernetes has a default set of behaviors when dealing with CSI Drivers (for example, it calls the Attach/Detach operations by default). This object allows CSI drivers to specify how Kubernetes should interact with it.
more info https://kubernetes-csi.github.io/docs/csi-driver-object.html
Note:
Signed-off-by: prateekpandey14 [email protected]