refact(migration): update volume migration to run in parallel #52
+33
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates the volume migration code to update the SC by only one job when multiple jobs running in parallel. Signed-off-by: shubham <[email protected]>
handles error case in isSCMigrationRequired func Signed-off-by: shubham <[email protected]>
mittachaitu
approved these changes
Sep 21, 2020
pkg/migrate/cstor/volume.go
Outdated
| } | ||
| return false, err | ||
| } | ||
| if err == nil { |
Signed-off-by: shubham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: shubham [email protected]
This PR updates the volume migration code to update the SC by only one job when multiple jobs running in parallel.
Local test performed:
Tested by launching 3 migration jobs in parallel and the job failure did not occur. Tried the same test 5 times and did not face the issue.