-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(upgrade): add support for UpgradeTask CR #11
Conversation
Signed-off-by: shubham <[email protected]>
Signed-off-by: shubham <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. We can merge after @sagarkrsd is ok with this as well.
@shubham14bajpai - could you also update this PR with any tests that were performed. |
Signed-off-by: shubham <[email protected]>
Signed-off-by: shubham <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Some minor comments only.
Signed-off-by: shubham <[email protected]>
This PR adds support for upgrades via UpgradeTask CRs. This enables users to create UpgradeTask CRs for the resources to be upgraded and group them using labels. Then a job can be launched with the env
UPGRADE_TASK_LABEL
which will list and upgrade the resources sequentially. For more details refer: https://github.com/openebs/openebs/blob/master/contribute/design/1.x/upgrade/volume-pools-upgrade.mdThis PR also fixes the issue: openebs/openebs#3069
Now the upgrade job does not defaults to
quay.io/openebs
as the prefix but will take whatever the prefix was on the previous version as default.Sample test result: