[stable/ndm]: add node selector and toleration to ndm exporter #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add toleration and node selector for NDM exporter pods - update chart version - update values.yaml - update README Signed-off-by: Akhil Mohan <[email protected]>
Ab-hishek
previously approved these changes
Jan 28, 2022
z0marlin
reviewed
Jan 30, 2022
z0marlin
previously approved these changes
Jan 30, 2022
xunholy
reviewed
Jan 31, 2022
Signed-off-by: Akhil Mohan <[email protected]>
|
Updated the indent in image pull secrets. @sonasingh46 Do you remember why we made image pull secrets different from other keys like tolerations and nodeselector. When I tested, I see that both of the methods are working. |
|
@xunholy and @Ab-hishek can you take a look at the PR? |
|
@akhilerm can we merge this one? RC1 branching is already done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes : openebs/charts#301
Signed-off-by: Akhil Mohan [email protected]