fix(webhook): populate admissionReviewVersions as a required value #1798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prateekpandey14
force-pushed
the
add-admission-review
branch
from
e56d8e9 to
d1ec659
Compare
Signed-off-by: prateekpandey14 <[email protected]>
prateekpandey14
force-pushed
the
add-admission-review
branch
from
d1ec659 to
a8f5164
Compare
Signed-off-by: prateekpandey14 <[email protected]>
Signed-off-by: prateekpandey14 <[email protected]>
prateekpandey14
force-pushed
the
add-admission-review
branch
from
e8f211c to
dd0b492
Compare
Signed-off-by: shubham <[email protected]>
Signed-off-by: prateekpandey14 <[email protected]>
prateekpandey14
force-pushed
the
add-admission-review
branch
from
8b86a3b to
a3ebc3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: prateekpandey14 [email protected]
Pull Request template
Please, go through these steps before you submit a PR.
Why is this PR required? What issue does it fix?:
What this PR does?:
Add admissionReviewVersions as
v1version since its a required value to be populated with v1 admission apis in k8s 1.20+ release onwards.Does this PR require any upgrade changes?:
Yes, upgrade has been handled internally
Checklist:
<type>(<scope>): <subject>