fix(localpv-hostpath): pv deletion caused panic when node not found #1664
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #1662
After the PV is created and node affinity is set
based on kubernetes.io/hostname label, either:
This PR fixes the panic, by logging the details
of the node hostname that no longer exists
in the cluster.
The code doesn't force delete the PV, considering that
the node might intermittently be out of the cluster.
If the user decides that node is not going to come back,
then the user can go ahead with force delete of pv using
kubectl delete pv
.An alternate case is that node hostname has really changed.
In this case, user will have to perform a manual migration
of the localpv-hostpath PV to the new node using the
following steps:
Note: when re-applying the yamls, the uuid of pv and pvc objects
will change, so the metadata around self-uuid,etc needs to be
cleared.
Signed-off-by: kmova [email protected]
(cherry picked from commit 728a003)