fix(cspc): replace the spc label with cspc label #1611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shubham <[email protected]>
shubham14bajpai
requested review from
mittachaitu,
prateekpandey14 and
sonasingh46
mittachaitu
reviewed
Feb 11, 2020
| @@ -332,7 +332,7 @@ func (pc *PoolConfig) removeCSPCFinalizer() error { | |||
| } | |||
|
|
|||
| cspList, err := apiscsp.NewKubeClient().List(metav1.ListOptions{ | |||
| LabelSelector: string(apis.StoragePoolClaimCPK) + "=" + pc.AlgorithmConfig.CSPC.Name, | |||
| LabelSelector: string(apis.CStorPoolClusterCPK) + "=" + pc.AlgorithmConfig.CSPC.Name, | |||
shubham14bajpai
added a commit
to shubham14bajpai/maya
that referenced
this pull request
Feb 11, 2020
Signed-off-by: shubham <[email protected]>
9 tasks
prateekpandey14
pushed a commit
that referenced
this pull request
Feb 11, 2020
Signed-off-by: shubham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: shubham [email protected]
What this PR does / why we need it:
This PR replaces the spc label with cspc label in the cspc-operator. If the finalizers are removed from the cspi and for some unknown reason the deletion is stuck then in that case the cspc should not be deleted before cspi deletion.