fix(mountpath): fix sock file mount path in pool deployments #1605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 5, 2020 01:02
Signed-off-by: mittachaitu <[email protected]>
Signed-off-by: mittachaitu <[email protected]>
mittachaitu
requested review from
shubham14bajpai,
prateekpandey14 and
vishnuitta
prateekpandey14
approved these changes
Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mittachaitu [email protected]
What this PR does / why we need it:
This PR fixes the shadow mount points in cStor-pool deployment by
updating sock file mount path from
/var/runto/var/tmp/sock.This PR handles upgrade changes and new cStor pool deployments.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #openebs/openebs#2902Special notes for your reviewer:
Tested the changes on gke(using disks) by building cstor-pool image and cstor-pool-mgmt image on top of cstor-pool image.(Test images: mittachaitu/cstor-pool:sock_path1, mittachaitu/cstor-pool-mgmt:fix_sock1)
Checklist:
documentationtagbreaking-changestagrequires-upgradetag