Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jiva-cleanup): allow cleanup jobs to run as previleged mode #1600

Merged
merged 1 commit into from
Feb 5, 2020

Conversation

utkarshmani1997
Copy link
Contributor

@utkarshmani1997 utkarshmani1997 commented Jan 31, 2020

Signed-off-by: Utkarsh Mani Tripathi [email protected]

What this PR does / why we need it:
This commit fix the issue where scrub jobs were failing on openshift platform
or where non previleged pods are not allowed to access/modify hostpath.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes # openebs/openebs#2893

Special notes for your reviewer:
none
Checklist:

  • Fixes Permissions denied to JIVA cleanup job to remove the volume content  openebs/openebs#2893
  • Labelled this PR & related issue with documentation tag
  • PR messages has document related information
  • Labelled this PR & related issue with breaking-changes tag
  • PR messages has breaking changes related information
  • Labelled this PR & related issue with requires-upgrade tag
  • PR messages has upgrade related information
  • Commit has unit tests
  • Commit has integration tests

This commit fix the issue where scrub jobs were failing on openshift platform
or where non previleged pods are not allowed to access/modify hostpath.

Signed-off-by: Utkarsh Mani Tripathi <[email protected]>
@vishnuitta vishnuitta requested review from kmova and payes February 1, 2020 18:53
Copy link
Contributor

@kmova kmova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it needs access to hostpath, same settings as replica pods will be required.

pkg/install/v1alpha1/jiva_volume.go Show resolved Hide resolved
Copy link
Contributor

@vishnuitta vishnuitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are good

@vishnuitta vishnuitta merged commit f254dde into openebs-archive:master Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Permissions denied to JIVA cleanup job to remove the volume content
3 participants