fix(validation): fix a bug in CSPC general validations #1598
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mittachaitu [email protected]
What this PR does / why we need it:
This PR fixes the bug in the admission server whether claimed block device claimed by other CSPC/third parties.
Actual bug:
Getting CSPC name from the annotation of blockdeviceclaim. Actually CSPC name should be fetched from blockdeviceclaim labels.
How Bug is skipped:
Used wrapf without any errors so it returns nil (https://github.com/pkg/errors/blob/614d223910a179a466c1767a985424175c39b465/errors.go#L202)
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Checklist:
documentation
tagbreaking-changes
tagrequires-upgrade
tag