Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(validation): fix a bug in CSPC general validations #1598

Merged
merged 1 commit into from
Jan 30, 2020

Conversation

mittachaitu
Copy link

Signed-off-by: mittachaitu [email protected]
What this PR does / why we need it:
This PR fixes the bug in the admission server whether claimed block device claimed by other CSPC/third parties.

Actual bug:
Getting CSPC name from the annotation of blockdeviceclaim. Actually CSPC name should be fetched from blockdeviceclaim labels.

How Bug is skipped:
Used wrapf without any errors so it returns nil (https://github.com/pkg/errors/blob/614d223910a179a466c1767a985424175c39b465/errors.go#L202)

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Checklist:

  • Fixes #
  • Labelled this PR & related issue with documentation tag
  • PR messages has document related information
  • Labelled this PR & related issue with breaking-changes tag
  • PR messages has breaking changes related information
  • Labelled this PR & related issue with requires-upgrade tag
  • PR messages has upgrade related information
  • Commit has unit tests
  • Commit has integration tests

Copy link
Contributor

@vishnuitta vishnuitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are good

Copy link
Contributor

@prateekpandey14 prateekpandey14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vishnuitta vishnuitta merged commit 8f77fb9 into openebs-archive:master Jan 30, 2020
@kmova kmova added this to the 1.7.0 milestone Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants