fix(cStor, deployments): add OpenEBS base directory in deployments #1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mittachaitu <[email protected]>
vishnuitta
reviewed
Jan 9, 2020
added 2 commits
January 9, 2020 16:10
Signed-off-by: mittachaitu <[email protected]>
Signed-off-by: mittachaitu <[email protected]>
mittachaitu
added
the
pr/upgrade-changes-pending
pawanpraka1
reviewed
Jan 9, 2020
pkg/install/v1alpha1/cstor_volume.go
Outdated
| @@ -579,6 +586,8 @@ spec: | |||
| mountPath: /var/run | |||
| - name: conf | |||
| mountPath: /usr/local/etc/istgt | |||
| - name: storagepath | |||
| mountPath: {{ .Config.PersistentStoragePath.value }} | |||
There was a problem hiding this comment.
why PersistentStoragePath variable is needed? it has to be "/var/openebs" all the time, other wise istgt image needs to be regenerated with the new mount path? isn't it?
There was a problem hiding this comment.
Yes, If that variable changed then istgt image also needs to be regenerated. So one shouldn't touch that PersistentStoragePath variable(Made comments above that variable).
We are using in different places so made variable to make it use.
Signed-off-by: mittachaitu <[email protected]>
9 tasks
mittachaitu
pushed a commit
to mittachaitu/maya
that referenced
this pull request
Jan 10, 2020
…penebs-archive#1583) Signed-off-by: mittachaitu <[email protected]>
9 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mittachaitu [email protected]
What this PR does / why we need it:
This PR mounts the
/var/openebsof the container into OPENEBS_IO_BASE_DIR/<cstor_target/pool>/<resource_name> on the host path.These changes are made to persist core files on the host path.
How Users Can Configure
Users can specify the value of OPENEBS_IO_BASE_DIR in Maya deployment.
While creating cStor pool/volume corresponding component will read the ENV value
and use base_dir for mounting. If ENV doesn't exist base_dir will mount
/var/openebs.Below are PR's to support dumping core in /var/openebs/core inside a container:
cStor: mayadata-io/cstor#284
istgt: openebs-archive/istgt#298
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
These changes are for SPC type of provisioning subsequent PRs will be raised for CSPC.
Checklist:
documentationtagbreaking-changestagrequires-upgradetag