refact(cvc): move cvc operator to its own deployment #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prateekpandey14
force-pushed
the
mv-cvc-controller
branch
from
6513dfc to
7ee6dfa
Compare
prateekpandey14
requested review from
sonasingh46,
mittachaitu,
payes and
shubham14bajpai
mittachaitu
reviewed
Dec 23, 2019
Signed-off-by: prateekpandey14 <[email protected]>
prateekpandey14
force-pushed
the
mv-cvc-controller
branch
from
7ee6dfa to
6bc7c5e
Compare
kmova
reviewed
Dec 28, 2019
kmova
suggested changes
Dec 28, 2019
kmova
changed the title
prateekpandey14
changed the title
Signed-off-by: prateekpandey14 <[email protected]>
prateekpandey14
force-pushed
the
mv-cvc-controller
branch
from
75d0f4e to
e3bcb0e
Compare
kmova
approved these changes
Dec 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: prateekpandey14 [email protected]
What this PR does / why we need it:
Changes remove the cstorvolumeclaim controller go-routines from the maya-apiserver and will be deployed as its own pod in k8s cluster.
This changes required to be done as cvc controller is specific to CStor CSI volume provisioning and there is no depdencies in Maya-apiserver.
As part of moving further with buiding new controllers/operators specific to each components and there specific repos it will easier to maintain.
Special notes for your reviewer:
This requires a new deployment file to be added as part of cstor-operator, PR openebs/openebs#2868