fix(upgrade): add support for images having more than one ":" #1557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shubham <[email protected]>
golangcibot
reviewed
Dec 15, 2019
Signed-off-by: shubham <[email protected]>
davidkarlsen
approved these changes
Dec 15, 2019
Signed-off-by: shubham <[email protected]>
AmitKumarDas
changed the title
shubham14bajpai
added a commit
to shubham14bajpai/maya
that referenced
this pull request
Dec 15, 2019
…s-archive#1557) * fix(upgarde): add support for images having more than one ":" Signed-off-by: shubham <[email protected]>
9 tasks
|
Which tag is this? https://quay.io/repository/openebs/m-upgrade?tab=tags |
kmova
pushed a commit
that referenced
this pull request
Dec 15, 2019
* fix(upgarde): add support for images having more than one ":" Signed-off-by: shubham <[email protected]>
|
Just ran the jobs to upgrade - works excellent using |
shubham14bajpai
added a commit
to shubham14bajpai/maya
that referenced
this pull request
Dec 27, 2019
…s-archive#1557) * fix(upgarde): add support for images having more than one ":" Signed-off-by: shubham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: shubham [email protected]
What this PR does / why we need it:
This PR fixes the
getBaseImagefunction which only expected only one:to be present before the image tag. There can be cases where proxy image url can have more than one:.Refer: openebs/openebs#2857
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Checklist:
documentationtagbreaking-changestagrequires-upgradetag