fix(provisioner, localpv): add service account to helper pods #1542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akhil Mohan <[email protected]>
Signed-off-by: Akhil Mohan <[email protected]>
add service account name and privileged context to helper pods launched by localpv provisioner. Both the init and cleanup pods require to be in privileged context so that the operations can be done on openshift/coreos based clusters. Signed-off-by: Akhil Mohan <[email protected]>
Signed-off-by: Akhil Mohan <[email protected]>
kmova
approved these changes
Dec 4, 2019
kmova
added a commit
to kmova/openebs
that referenced
this pull request
Dec 4, 2019
Starting with 1.5, the helper pod image will be same across ndm and openebs components. updated it with the latest tagged image. Refer: openebs-archive/maya#1538, openebs-archive/node-disk-manager#352 As a fix for openshift local hostpath, the helper pods need to be launched with service account. Updated the local provisioner with ENV. Refer: openebs-archive/maya#1542 Signed-off-by: kmova <[email protected]>
vishnuitta
pushed a commit
to openebs/openebs
that referenced
this pull request
Dec 5, 2019
Starting with 1.5, the helper pod image will be same across ndm and openebs components. updated it with the latest tagged image. Refer: openebs-archive/maya#1538, openebs-archive/node-disk-manager#352 As a fix for openshift local hostpath, the helper pods need to be launched with service account. Updated the local provisioner with ENV. Refer: openebs-archive/maya#1542 Signed-off-by: kmova <[email protected]>
shubham14bajpai
pushed a commit
to shubham14bajpai/maya
that referenced
this pull request
Dec 27, 2019
…s-archive#1542) add service account name and privileged context to helper pods launched by localpv provisioner. Both the init and cleanup pods require to be in privileged context so that the operations can be done on openshift/coreos based clusters. * chore(builder): add builder for SA name * fix(env): add functions to get openebs service account * fix(provisioner, local): add SA to helper pod * chore(unit-test): add test cases for getOpenEBSServiceAccount Signed-off-by: Akhil Mohan <[email protected]>
akhilerm
added a commit
to akhilerm/maya
that referenced
this pull request
Dec 30, 2019
while creating cleanup pod for openebs-hostpath, service account name needs to be given. openebs-archive#1542 added service account only to init pod. This will add the service account to cleanup pod also. Signed-off-by: Akhil Mohan <[email protected]>
kmova
pushed a commit
that referenced
this pull request
Dec 31, 2019
while creating cleanup pod for openebs-hostpath, service account name needs to be given. #1542 added service account only to init pod. This will add the service account to cleanup pod also. Signed-off-by: Akhil Mohan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds openebs service account to the pods launched by local-pv provisioner. This is because in Openshift / CoreOS clusters, the pods need to be in privileged security context and should use the openebs service account which has a privileged SCC in openshift.