Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refact(k8s-volumes): add configMap & secret based volume builder #1537

Merged
merged 7 commits into from
Dec 6, 2019
Merged

refact(k8s-volumes): add configMap & secret based volume builder #1537

merged 7 commits into from
Dec 6, 2019

Conversation

rahulchheda
Copy link
Contributor

@rahulchheda rahulchheda commented Nov 28, 2019 •
edited
Loading

What this PR does / why we need it:

  • This is a PR for builder functions present in pkg/kubernetes
    Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

  • Some testing is done, by checking the creation of Volume
  • Have set the volume name to be the respective resource Name (for right now, please comment on the PR, if some modification is needed)

Checklist:

  • Fixes #
  • Labelled this PR & related issue with documentation tag
  • PR messages has document related information
  • Labelled this PR & related issue with breaking-changes tag
  • PR messages has breaking changes related information
  • Labelled this PR & related issue with requires-upgrade tag
  • PR messages has upgrade related information
  • Commit has unit tests
  • Commit has integration tests

@rahulchheda rahulchheda changed the title refact(k8s-volumes): add configMap based volume builder refact(k8s-volumes): add configMap & secret based volume builder Nov 28, 2019
@kmova kmova self-requested a review November 29, 2019 06:50
mittachaitu
mittachaitu approved these changes Dec 6, 2019
View reviewed changes
Copy link

@mittachaitu mittachaitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are good

prateekpandey14
prateekpandey14 approved these changes Dec 6, 2019
View reviewed changes
Copy link
Contributor

@prateekpandey14 prateekpandey14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@kmova kmova merged commit 0e0cb2b into openebs-archive:master Dec 6, 2019
@kmova kmova added this to the 1.5.0 milestone Dec 6, 2019
shubham14bajpai pushed a commit to shubham14bajpai/maya that referenced this pull request Dec 27, 2019
@rahulchheda @shubham14bajpai
refact(k8s-volumes): add configMap & secret based volume builder (ope…
d4269f3 
…nebs-archive#1537)

Enhance volume builder to include configmaps and secrets.

Signed-off-by: Rahul M Chheda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mittachaitu mittachaitu mittachaitu approved these changes

@kmova kmova kmova approved these changes

@prateekpandey14 prateekpandey14 prateekpandey14 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@rahulchheda @prateekpandey14 @kmova @mittachaitu