refact(admission): automate deletion of older config #1521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shubham <[email protected]>
Signed-off-by: shubham <[email protected]>
prateekpandey14
pushed a commit
to prateekpandey14/maya
that referenced
this pull request
Nov 13, 2019
…#1521) * refact(admission): automate deletion of older config * refactored code to use builders Signed-off-by: shubham <[email protected]>
vishnuitta
pushed a commit
that referenced
this pull request
Nov 13, 2019
Signed-off-by: shubham <[email protected]>
shubham14bajpai
added a commit
to shubham14bajpai/maya
that referenced
this pull request
Dec 27, 2019
…#1521) * refact(admission): automate deletion of older config * refactored code to use builders Signed-off-by: shubham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: shubham [email protected]
What this PR does / why we need it:
This PR automates the deletion of older admission webhook configurations. It also adds version label to new configs to differentiate between old and new configs.
This will require addition of
listclusterrole forvalidatingwebhookconfig.Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Checklist:
documentationtagbreaking-changestagrequires-upgradetag