feat(cstor-operator): filter out released block devices during auto provisioning #1310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es during auto provisioning Signed-off-by: mittachaitu <[email protected]>
mittachaitu
requested review from
AmitKumarDas,
prateekpandey14,
vishnuitta and
sonasingh46
mittachaitu
changed the title
prateekpandey14
approved these changes
Jun 19, 2019
kmova
reviewed
Jun 19, 2019
| @@ -289,6 +291,19 @@ func filterNonSparseDevices(originalList *BlockDeviceList) *BlockDeviceList { | |||
| return filteredList | |||
| } | |||
|
|
|||
| func filterNonRelesedDevices(originalList *BlockDeviceList) *BlockDeviceList { | |||
There was a problem hiding this comment.
Let us write a comment for this function. Is this supposed to return a list of BDs whose claimstate is "Released" ?
There was a problem hiding this comment.
It will return BDs whose claimstate is other than Released. Will add a comment in next PR
| FilterSparseDevices = "filterSparseDevices" | ||
| FilterNonSparseDevices = "filterNonSparseDevices" | ||
| InActiveStatus = "Inactive" | ||
| FilterNonRelesedDevices = "filterNonRelesedDevices" |
There was a problem hiding this comment.
Corrected in cherry-pick PR will do it in next PR
mittachaitu
pushed a commit
to mittachaitu/maya
that referenced
this pull request
Jun 19, 2019
…rovisioning (openebs-archive#1310) Signed-off-by: mittachaitu <[email protected]>
vishnuitta
pushed a commit
that referenced
this pull request
Jun 19, 2019
… during auto provisioning (#1312) * fix(cstor-operator): honour spc type in case of manual provisioning of cStor pool (#1281) Signed-off-by: mittachaitu <[email protected]> * feat(cstor-operator): filter out released block devices during auto provisioning (#1310) Signed-off-by: mittachaitu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mittachaitu [email protected]
What this PR does / why we need it:
This PR adds the filter to filter out block devices which are in released state during auto provision mode.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Checklist:
documentationtagbreaking-changestagrequires-upgradetag