fix(cvr, delete): ensure cvr gets deleted during reconcile #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmitKumarDas
requested review from
sonasingh46,
gprasath,
kmova,
mittachaitu,
mynktl,
prateekpandey14,
ranjithwingrider and
vishnuitta
AmitKumarDas
force-pushed
the
cvr-del-finalizer-take-2-part-2
branch
2 times, most recently
from
fdaf96a to
5d1a3d5
Compare
ghost
reviewed
Jun 7, 2019
There was a problem hiding this comment.
Found some fixes!
P.S. share your ideas, feedbacks or issues with us at https://github.com/fixmie/feedback (this message will be removed after the beta stage).
AmitKumarDas
force-pushed
the
cvr-del-finalizer-take-2-part-2
branch
from
5d1a3d5 to
0ff8819
Compare
vishnuitta
reviewed
Jun 7, 2019
| string(common.StatusSynced), | ||
| ) | ||
|
|
||
| } else if IsDestroyEvent(newCVR) { |
There was a problem hiding this comment.
is it good if we reverse this and the above 'if', i.e., how about below order:
if IsDestroyEvent(newCVR) {
} else if newCVR.ResourceVersion == oldCVR.ResourceVersion{
}else {
}
There was a problem hiding this comment.
what is the motivation for above? @vishnuitta
AmitKumarDas
force-pushed
the
cvr-del-finalizer-take-2-part-2
branch
from
0ff8819 to
d9cf911
Compare
mynktl
approved these changes
Jun 7, 2019
| oldCVR := old.(*apis.CStorVolumeReplica) | ||
|
|
||
| glog.V(4).Infof( | ||
| "received informer update event for cvr {%s}", |
There was a problem hiding this comment.
can we log this after IsRightCStorVolumeReplica check?
This commit has following changes: - remove the check where reconcile was avoided in case of previous delete failures - reduce instances of log flooding - improve log messages - modify & indent code to make it more readable Related PR(s): - openebs-archive#1256 This commit tries to fix the symptom 2 talked in PR 1256 Signed-off-by: AmitKumarDas <[email protected]>
AmitKumarDas
force-pushed
the
cvr-del-finalizer-take-2-part-2
branch
from
d9cf911 to
01aa52e
Compare
prateekpandey14
pushed a commit
to prateekpandey14/maya
that referenced
this pull request
Jun 19, 2019
…rchive#1263) This commit has following changes: - remove the check where reconcile was avoided in case of previous delete failures - reduce instances of log flooding - improve log messages - modify & indent code to make it more readable Related PR(s): - openebs-archive#1256 This commit tries to fix the symptom 2 talked in PR 1256 Signed-off-by: AmitKumarDas <[email protected]>
kmova
pushed a commit
that referenced
this pull request
Jun 19, 2019
This commit has following changes: - remove the check where reconcile was avoided in case of previous delete failures - reduce instances of log flooding - improve log messages - modify & indent code to make it more readable Related PR(s): - #1256 This commit tries to fix the symptom 2 talked in PR 1256 Signed-off-by: AmitKumarDas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit has following changes:
Related PR(s):
This commit tries to fix the symptom 2 talked in PR 1256
Signed-off-by: AmitKumarDas [email protected]
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Checklist:
documentationtagbreaking-changestagrequires-upgradetag