fix(localpv): handle case of BDC-BD taking longer time #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a PVC with Local PV host device is triggered, Local PV provisioner will create BDC and waits for 60 seconds to get the BD attached. Post that it returns the control back to K8s. K8s will re-attempt to create a PV, and in the second iteration - the Local PV provisioner will check if the BDC was already created and will try to re-use it instead of creating another one. Creating another BDC, in the setup where BD/BDC takes longer will never result in PV getting created. Also, timing out and reporting the error to user will make the process intuitive when BD/BDC process is taking longer. Signed-off-by: kmova <[email protected]>
shubham14bajpai
pushed a commit
to shubham14bajpai/maya
that referenced
this pull request
Jun 7, 2019
…ve#1262) When a PVC with Local PV host device is triggered, Local PV provisioner will create BDC and waits for 60 seconds to get the BD attached. Post that it returns the control back to K8s. K8s will re-attempt to create a PV, and in the second iteration - the Local PV provisioner will check if the BDC was already created and will try to re-use it instead of creating another one. Creating another BDC, in the setup where BD/BDC takes longer will never result in PV getting created. Also, timing out and reporting the error to user will make the process intuitive when BD/BDC process is taking longer. Signed-off-by: kmova <[email protected]>
9 tasks
shubham14bajpai
pushed a commit
to shubham14bajpai/maya
that referenced
this pull request
Jun 7, 2019
…ve#1262) When a PVC with Local PV host device is triggered, Local PV provisioner will create BDC and waits for 60 seconds to get the BD attached. Post that it returns the control back to K8s. K8s will re-attempt to create a PV, and in the second iteration - the Local PV provisioner will check if the BDC was already created and will try to re-use it instead of creating another one. Creating another BDC, in the setup where BD/BDC takes longer will never result in PV getting created. Also, timing out and reporting the error to user will make the process intuitive when BD/BDC process is taking longer. Signed-off-by: kmova <[email protected]>
prateekpandey14
pushed a commit
that referenced
this pull request
Jun 7, 2019
When a PVC with Local PV host device is triggered, Local PV provisioner will create BDC and waits for 60 seconds to get the BD attached. Post that it returns the control back to K8s. K8s will re-attempt to create a PV, and in the second iteration - the Local PV provisioner will check if the BDC was already created and will try to re-use it instead of creating another one. Creating another BDC, in the setup where BD/BDC takes longer will never result in PV getting created. Also, timing out and reporting the error to user will make the process intuitive when BD/BDC process is taking longer. Signed-off-by: kmova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a PVC with Local PV host device is triggered,
Local PV provisioner will create BDC and waits
for 60 seconds to get the BD attached. Post that
it returns the control back to K8s.
K8s will re-attempt to create a PV, and in
the second iteration - the Local PV provisioner
will check if the BDC was already created
and will try to re-use it instead of creating another one.
Creating another BDC, in the setup where BD/BDC takes
longer will never result in PV getting created. Also,
timing out and reporting the error to user will make the
process intuitive when BD/BDC process is taking longer.
Signed-off-by: kmova [email protected]
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Checklist:
documentationtagbreaking-changestagrequires-upgradetag