add volume controller and volume replica node level taint toleration #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Why is this change necessary ? It has been seen that a K8s setup might dedicate some K8s nodes for control plane while some other nodes for storage plane. This change will be able to handle such setup needs. This will fix openebs/openebs#512 2. How does this change address the issue ? - accepts node taint toleration for volume controller - accepts node taint toleration for volume replica - understands ENV variable for above - modifies buildscripts as apiserver is now under maya repository. 3. How to verify this change ? - Refer Issue openebs/openebs#600 - Get a K8s 1.8 or above setup - Taint the nodes with appropriate taint key & value - Create volume with node taint toleration enabled for volume Controller - Verify if volume controller was placed in the appropriate tainted node - Create volume with node taint toleration enabled for volume Replica - Verify if volume replica was placed in the appropriate tainted node 4. What side effects does this change have ? - The volume controller & replica placement logic is impacted - This is an optional feature
Codecov Report
@@ Coverage Diff @@
## master #106 +/- ##
==========================================
+ Coverage 19.59% 19.86% +0.27%
==========================================
Files 58 58
Lines 7360 7419 +59
==========================================
+ Hits 1442 1474 +32
- Misses 5818 5838 +20
- Partials 100 107 +7
Continue to review full report at Codecov.
|
prateekpandey14
suggested changes
Oct 11, 2017
1. Why is this change necessary ? The source code generally does not have the binaries. Previous commit had uploaded these binaries. 2. How does this change address the issue ? - Modified the makefile which will prevent the issue in first place - Removed the binaries from git 3. How to verify this change ? - ll of buildscripts/apiserver will not show binaries 4. What side effects does this change have ? - None
|
@prateekpandey14 Done.. |
|
lgtm |
prateekpandey14
approved these changes
Oct 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been seen that a K8s setup might dedicate some
K8s nodes for control plane while some other nodes
for storage plane. This change will be able to handle
such setup needs.
This will fix openebs/openebs#512
accepts node taint toleration for volume controller
accepts node taint toleration for volume replica
understands ENV variable for above
modifies buildscripts as apiserver is now under maya
repository.
Refer Issue Create docs about setting volume Controller & Replica Pods with node level taint tolerations openebs/openebs#600
Get a K8s 1.8 or above setup
Taint the nodes with appropriate taint key & value
Create volume with node taint toleration enabled for volume
Controller
Verify if volume controller was placed in the appropriate
tainted node
Create volume with node taint toleration enabled for
volume Replica
Verify if volume replica was placed in the appropriate
tainted node
The volume controller & replica placement logic is
impacted
This is an optional feature
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: