Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(actions): fix the image tag for branches #348

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

shubham14bajpai
Copy link
Contributor

Signed-off-by: shubham [email protected]

This Pr fixes the tags for branches other than master. The images pushed via build workflow for branches should have -ci at the end which is missing due to a variable mismatch. The TAG variable is used by the build_binary script so keeping the variable with a different name.
https://github.com/openebs/jiva/blob/d3d9f36eae48befafcbe2396f9fa6bd235e50525/.github/workflows/build.yml#L103

Copy link

@akhilerm akhilerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akhilerm akhilerm merged commit d2ae366 into openebs-archive:master Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants