Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact(UUID): include replica address while creating UUID hash #344

Merged
merged 3 commits into from
Feb 7, 2021

Conversation

payes
Copy link
Contributor

@payes payes commented Feb 3, 2021

This PR implements the following:

  1. Update go version to 1.14.7
  2. Avoid using Dir global variable in replica package to aid unit testing.
  3. Use replica IP to create UUID hash
    Signed-off-by: Payes Anand [email protected]

@payes payes changed the title include replica address while creating UUID hash refact(UUID): include replica address while creating UUID hash Feb 3, 2021
payes added 2 commits February 4, 2021 12:53
Signed-off-by: Payes Anand <[email protected]>
Signed-off-by: Payes Anand <[email protected]>
@kmova kmova requested a review from utkarshmani1997 February 5, 2021 15:18
@kmova
Copy link
Contributor

kmova commented Feb 5, 2021

@payes - can you update the PR with details like why this change is required and what has been done?

@kmova kmova merged commit 59be181 into openebs-archive:master Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants