[TA325, TA329] fix the error messages in clone/sync process #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On branch US1680-fix-logs-on-sync-with-sc Changes to be committed: modified: sync/sync.go 1. Why is this change necessary? - To provide more descriptive error messages to the user. 2. How does it address the issue? - Appended the errors also in the logs messages to know the cause of error. 3. What side effects does this change have? - None 4. How to verify this change? - Deploy the clone replica and you will be able to see more desriptive logs and errors. 5. Any specific message for reviewer ? - No Signed-off-by: Utkarsh Mani Tripathi <[email protected]>
kmova
approved these changes
Aug 27, 2018
payes
approved these changes
Aug 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On branch US1680-fix-logs-on-sync-with-sc
Changes to be committed:
modified: sync/sync.go
errors.
Signed-off-by: Utkarsh Mani Tripathi [email protected]