-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[US2662] check if underlying filesystem supports extents mapping. #105
[US2662] check if underlying filesystem supports extents mapping. #105
Conversation
On branch US2662-verify-file-extents-mapping Changes to be committed: modified: ci/start_init_test.sh modified: replica/replica.go 1. Why is this change necessary? - To verify whether the underlying filesystem supports extents mapping. 2. How does it address the issue? - In the earlier code we were ignoring the error which verifies if the filesystem supports extents mapping. So now we will catch the error and error out the replica. 3. What side effects does this change have? - None. 4. How to verify this change? - ci is already added to verify the changes. 5. Any specific message for reviewer ? - No Signed-off-by: Utkarsh Mani Tripathi <[email protected]>
Signed-off-by: Utkarsh Mani Tripathi <[email protected]>
Signed-off-by: Utkarsh Mani Tripathi <[email protected]>
@@ -224,7 +224,11 @@ func construct(readonly bool, size, sectorSize int64, dir, head string, backingF | |||
r.insertBackingFile() | |||
r.ReplicaType = replicaType | |||
|
|||
PreloadLunMap(&r.volume) | |||
if err := PreloadLunMap(&r.volume); err != nil { | |||
logrus.Error("underlying file system does not support extent mapping") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets also print the actual error received.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are returning the error to the callee, callee is printing the error : "operation not permitted". So printing the error here will pollute the logs unneccessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed
On branch US2662-verify-file-extents-mapping
Changes to be committed:
modified: ci/start_init_test.sh
modified: replica/replica.go
filesystem supports extents mapping. So now we will catch the error
and error out the replica.
Signed-off-by: Utkarsh Mani Tripathi [email protected]