[US2662] check if underlying filesystem supports extents mapping. #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On branch US2662-verify-file-extents-mapping Changes to be committed: modified: ci/start_init_test.sh modified: replica/replica.go 1. Why is this change necessary? - To verify whether the underlying filesystem supports extents mapping. 2. How does it address the issue? - In the earlier code we were ignoring the error which verifies if the filesystem supports extents mapping. So now we will catch the error and error out the replica. 3. What side effects does this change have? - None. 4. How to verify this change? - ci is already added to verify the changes. 5. Any specific message for reviewer ? - No Signed-off-by: Utkarsh Mani Tripathi <[email protected]>
Signed-off-by: Utkarsh Mani Tripathi <[email protected]>
Signed-off-by: Utkarsh Mani Tripathi <[email protected]>
payes
reviewed
Aug 27, 2018
| @@ -224,7 +224,11 @@ func construct(readonly bool, size, sectorSize int64, dir, head string, backingF | |||
| r.insertBackingFile() | |||
| r.ReplicaType = replicaType | |||
|
|
|||
| PreloadLunMap(&r.volume) | |||
| if err := PreloadLunMap(&r.volume); err != nil { | |||
| logrus.Error("underlying file system does not support extent mapping") | |||
There was a problem hiding this comment.
Lets also print the actual error received.
There was a problem hiding this comment.
We are returning the error to the callee, callee is printing the error : "operation not permitted". So printing the error here will pollute the logs unneccessary.
payes
approved these changes
Aug 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On branch US2662-verify-file-extents-mapping
Changes to be committed:
modified: ci/start_init_test.sh
modified: replica/replica.go
filesystem supports extents mapping. So now we will catch the error
and error out the replica.
Signed-off-by: Utkarsh Mani Tripathi [email protected]