Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): update default/build branch from replication to develop… #360

Merged
merged 1 commit into from
Sep 13, 2021

Conversation

kmova
Copy link
Contributor

@kmova kmova commented Sep 13, 2021

… (#359)

  • updating branch reference from replication to develop
  • CONTRIBUTING.md
  • README.md
  • RELEASE.md
  • developer-setup.md
  • GOVERNANCE.md
  • fetch-libcstor-branch.sh
  • code-standard.md
  • updating build branch to 'develop' in github workflow
  • add ghcr as an container repository to host container images

Signed-off-by: mittachaitu [email protected]

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Checklist:

  • Fixes #
  • Labelled this PR & related issue with documentation tag
  • PR messages has document related information
  • Labelled this PR & related issue with breaking-changes tag
  • PR messages has breaking changes related information
  • Labelled this PR & related issue with requires-upgrade tag
  • PR messages has upgrade related information
  • Commit has unit tests
  • Commit has integration tests

…#359)

* updating branch reference from replication to develop

- CONTRIBUTING.md
- README.md
- RELEASE.md
- developer-setup.md
- GOVERNANCE.md
- fetch-libcstor-branch.sh
- code-standard.md

* updating build branch to 'develop' in github workflow
* add ghcr as an container repository to host container images

Signed-off-by: mittachaitu <[email protected]>
@@ -37,8 +37,8 @@ set -e
#For the moment, we will go with making sure the correct
# branch name is provided as part of the release process.
if [ -z ${TRAVIS_BRANCH} ] ||
[ ${TRAVIS_BRANCH} == "replication" ]; then
LIBCSTOR_BUILD_BRANCH="master"
[ ${TRAVIS_BRANCH} == "develop" ]; then

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086

@kmova kmova merged commit a9f0210 into v2.12.x Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant