feat(build): add support for building on arm and x86 #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to: openebs/openebs#1295 - modify build_image.sh to decide which arch is used Signed-off-by: wangzihao <[email protected]>
mynktl
approved these changes
Nov 25, 2019
build_image.sh
Outdated
|
|
||
| # Determine the arch/os we're building for | ||
| ARCH=$(uname -m) | ||
| OS=$(uname) |
There was a problem hiding this comment.
oh yes, I will delete it.
Signed-off-by: wangzihao <[email protected]>
pawanpraka1
reviewed
Nov 27, 2019
docker/Dockerfile.arm64
Outdated
| LABEL org.label-schema.name="cstor" | ||
| LABEL org.label-schema.description="OpenEBS cstor" | ||
| LABEL org.label-schema.url="http://www.openebs.io/" | ||
| LABEL org.label-schema.vcs-url="https://github.com/openebs/cstor" |
There was a problem hiding this comment.
it should be https://github.com/openebs/istgt.
pawanpraka1
reviewed
Nov 27, 2019
docker/Dockerfile.arm64
Outdated
| RUN chmod +x /usr/local/bin/entrypoint-istgtimage.sh | ||
|
|
||
| ARG BUILD_DATE | ||
| LABEL org.label-schema.name="cstor" |
pawanpraka1
reviewed
Nov 27, 2019
docker/Dockerfile.arm64
Outdated
|
|
||
| ARG BUILD_DATE | ||
| LABEL org.label-schema.name="cstor" | ||
| LABEL org.label-schema.description="OpenEBS cstor" |
|
Thanks @pawanpraka1 . I will update them. There are the same issue in Dockerfile. Should I update them both ? |
|
yes, please go ahead. Fix the existing Dockerfile also. |
Signed-off-by: wangzihao <[email protected]>
pawanpraka1
reviewed
Nov 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: openebs/openebs#1295
Signed-off-by: wangzihao [email protected]