-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metrics): Adding metrics for nfs-provisioner #51
Conversation
Signed-off-by: mayank <[email protected]>
Signed-off-by: mayank <[email protected]>
Signed-off-by: mayank <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: sai chaithanya <[email protected]>
Codecov Report
@@ Coverage Diff @@
## develop #51 +/- ##
========================================
Coverage 48.46% 48.46%
========================================
Files 18 18
Lines 1595 1595
========================================
Hits 773 773
Misses 778 778
Partials 44 44 Continue to review full report at Codecov.
|
prometheus.CounterOpts{ | ||
Subsystem: NfsVolumeProvisionerSubsystem, | ||
Name: "persistentvolume_delete_total", | ||
Help: "Total number of persistent volumes deleted", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Total" here refers to the total number of volumes deleted - by this provisioner pod.
I can think of one usecase for these metrics - to check on the health of the provisioner to see if provisioner is able to successfully create volume or if the failures are increasing.
Are there other usecase for these metrics?
Another interesting metric can be to expose the average duration taken for creation or deletion of the volumes. Probably these can be covered in CSI.
Overall good to merge after getting a response to the usecase query.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will help to check stale pv count also from persistentvolume_delete_failed_total
Signed-off-by: mayank [email protected]
Why is this PR required? What issue does it fix?:
What this PR does?:
This PR exposes metrics about nfs provisioning requests (create/delete). Following metrics are exposed:
Does this PR require any upgrade changes?: No
If the changes in this PR are manually verified, list down the scenarios covered::
Checklist:
<type>(<scope>): <subject>