Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(analytic): send install event on nfs-provisioner start #109

Merged
merged 1 commit into from
Sep 15, 2021

Conversation

mynktl
Copy link
Contributor

@mynktl mynktl commented Sep 15, 2021

Why is this PR required? What issue does it fix?:

What this PR does?:
This PR enable nfs-provisioner to send Installation and Ping event

Does this PR require any upgrade changes?:

If the changes in this PR are manually verified, list down the scenarios covered::

Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Does this PR change require updating NFS-Provisioner Chart? If yes, mention the Helm Chart PR #
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

@mynktl mynktl requested review from kmova and vharsh September 15, 2021 12:36
@codecov-commenter
Copy link

Codecov Report

Merging #109 (a0362a5) into develop (23d4176) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #109      +/-   ##
===========================================
- Coverage    46.97%   46.91%   -0.06%     
===========================================
  Files           29       29              
  Lines         2378     2381       +3     
===========================================
  Hits          1117     1117              
- Misses        1182     1185       +3     
  Partials        79       79              
Impacted Files Coverage Δ
provisioner/controller.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23d4176...a0362a5. Read the comment docs.

Copy link

@vharsh vharsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants