chore(docs): instruction guide on installing WordPress using OpenEBS NFS Volumes #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NFS Volumes Signed-off-by: mayank <[email protected]>
Codecov Report
@@ Coverage Diff @@
## develop #105 +/- ##
========================================
Coverage 46.97% 46.97%
========================================
Files 29 29
Lines 2378 2378
========================================
Hits 1117 1117
Misses 1182 1182
Partials 79 79 Continue to review full report at Codecov.
|
mittachaitu
approved these changes
Sep 13, 2021
| --set volumePermissions.enabled=true \ | ||
| --set autoscaling.enabled=true \ | ||
| --set autoscaling.minReplicas=1 \ | ||
| --set autoscaling.maxReplicas=6 \ |
There was a problem hiding this comment.
nit: As per scale command below it can be 1
Suggested change
| --set autoscaling.maxReplicas=6 \ | |
| --set autoscaling.maxReplicas=1 \ |
There was a problem hiding this comment.
Better to keep maxReplicas's as 2 here and then 3 in the scaled command below.
There was a problem hiding this comment.
removed scale command as autoscaling is enabled in helm install command
added 2 commits
September 13, 2021 16:19
Signed-off-by: mayank <[email protected]>
… command Signed-off-by: mayank <[email protected]>
kmova
approved these changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this PR required? What issue does it fix?:
What this PR does?:
This PR adds a document on how to install WordPress application using OpenEBS NFS Volumes.
Does this PR require any upgrade changes?:
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>